View Issue Details

IDProjectCategoryView StatusLast Update
0001276K18X001.00 SKB SWANSWpublic2021-08-18 15:32
Reporter(ALTech) Wooshin Kang Assigned To(ALTech) Wooshin Kang Due Date2021-06-10 15:34
PriorityhighSeveritys2-severeReproducibilityalways
Status closedResolutionfixed 
Summary0001276: [SWAN] Please apply patch for unmute issue.
Description< Issue >
When user set audio path to external audio in menu, after mute volume, if user change channel, sound output even though mute status.

< patch >
synaptics did release patch for it.
volume_unmute_after_changing_channel.diff

Please apply patch.

Thanks.
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

(ALTech) Wooshin Kang

2021-06-10 14:39

developer  

volume_unmute_after_changing_channel.diff (1,379 bytes)   
diff --git a/amp/src/aal/sound/sound_api.c b/amp/src/aal/sound/sound_api.c
index 7cf0a06..b6799c0 100755
--- a/amp/src/aal/sound/sound_api.c
+++ b/amp/src/aal/sound/sound_api.c
@@ -2950,6 +2950,7 @@ HRESULT AMP_SND_SetStreamVolume(HANDLE hStream, UINT uiVolume)
     SNDSTRM_CHECKVALID(hStream);
     pStream = (SND_STRM*) hStream;
     volume = AMP_SND_VOL_L2E(uiVolume);
+    pStream->uiStreamVolume = uiVolume;
     stAppParam._d = AMP_APP_PARAIDX_VOLUME;
     stAppParam._u.stVolume.uiVolume = volume;
 #ifdef CONFIG_AMP_AUDIO_GAIN_RANGE_EXTENSION
@@ -3485,8 +3486,14 @@ HRESULT AMP_SND_SetStreamMute(AMP_IN HANDLE hStream, AMP_IN BOOL bMute)
     {
 #ifdef CONFIG_AMP_AUDIO_MUTE_PT_FOR_STREAM
         SNDLOGD("HDMI pass through case, stream volume is set to AOUT!\n");
+#if 1 //tony debug
+        SNDLOGE("tony restore volume even for HDMI passthrough ! restore volume target:[%d] \n", pStream->uiStreamVolume);
+        AMP_RPC(rc, AMP_SNDSINK_SetAoutStreamVolume, pStream->hSndSinkComp,
+            HDMI_PATH, bMute? 0: (pStream->uiStreamVolume==0 ? 0:0x40000000L));
+#else
         AMP_RPC(rc, AMP_SNDSINK_SetAoutStreamVolume, pStream->hSndSinkComp,
             HDMI_PATH, bMute? 0: 0x40000000L);
+#endif
         if (rc != SUCCESS) {
             SNDLOGE("Fail to set aout stream volume with handle[0x%x]\n",
                      hStream);

(SW) Jacky Chiang

2021-06-10 22:31

manager   ~0007434

Hi Jason,

   Please help to apply this patch from Synaptics.

(SW) Jason Ling

2021-06-11 09:02

developer   ~0007437

Hi Wooshin,

Applied

commit 795027efe1dea0323eabda76cf5f0d946276bc06
Refs: [HEAD], {m/BFX-UA300_5.2.4}, {skb/BFX-UA300_5.2.4}
Author: Jason Ling <jason.tf.ling@fii-foxconn.com>
AuthorDate: Fri Jun 11 08:57:33 2021 +0800
Commit: Jason Ling <jason.tf.ling@fii-foxconn.com>
CommitDate: Fri Jun 11 08:57:33 2021 +0800

    [BTVSBOX-501] Fix unmute issue

    When user set audio path to external audio in menu, after mute volume, if user change channel, sound output even though mute status.
---

(ALTech) Wooshin Kang

2021-06-16 08:48

developer   ~0007473

Hi jason,

This issue is not solved by patch "volume_unmute_after_changing_channel.diff"
So, synaptics has released one more patch. Please apply it and previous one should be keep.
0001-ammend-of-BTVSBOX-501-Fix-unmute-issue-795027efe1dea.patch (801 bytes)   
From ee54ce6d24d56266750d9a4ac4c020ac63abc6b3 Mon Sep 17 00:00:00 2001
From: Tony Kim <Tony.Kim@synaptics.com>
Date: Tue, 15 Jun 2021 19:10:54 +0900
Subject: [PATCH] ammend of '[BTVSBOX-501] Fix unmute issue'-
 795027efe1dea0323eabda76cf5f0d946276bc06

---
 amp/src/aal/sound/sound_api.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/amp/src/aal/sound/sound_api.c b/amp/src/aal/sound/sound_api.c
index b6799c0..e8808f1 100755
--- a/amp/src/aal/sound/sound_api.c
+++ b/amp/src/aal/sound/sound_api.c
@@ -3093,6 +3093,9 @@ HRESULT AMP_SND_SetStreamVolumeIndB(AMP_IN HANDLE hStream, AMP_IN float fVolume)
                      hStream);
         }
 #endif
+#if 1  //tony debug
+        pStream->uiStreamVolume = uiVolume;
+#endif 
         return rc;
     }
 
-- 
2.7.4

(SW) Jason Ling

2021-06-16 11:01

developer   ~0007474

Hi Woooshin,

Applied,

commit af6021b6e656cd6c189d3f8cda3088d70e7e47c8
Refs: [HEAD], {m/BFX-UA300_5.2.4}, {skb/BFX-UA300_5.2.4}
Author: Tony Kim <Tony.Kim@synaptics.com>
AuthorDate: Tue Jun 15 19:10:54 2021 +0900
Commit: Jason Ling <jason.tf.ling@fii-foxconn.com>
CommitDate: Wed Jun 16 09:30:27 2021 +0800

    ammend of '[BTVSBOX-501] Fix unmute issue'- 795027efe1dea0323eabda76cf5f0d946276bc06

Brent will verify it.

(ALTech) Wooshin Kang

2021-06-16 15:49

developer   ~0007476

Hi Jason,

I will also check it.
Thanks.

(ALTech) Wooshin Kang

2021-08-18 15:32

developer   ~0007907

done

Issue History

Date Modified Username Field Change
2021-06-10 14:39 (ALTech) Wooshin Kang New Issue
2021-06-10 14:39 (ALTech) Wooshin Kang Status new => assigned
2021-06-10 14:39 (ALTech) Wooshin Kang Assigned To => (SW) Jacky Chiang
2021-06-10 14:39 (ALTech) Wooshin Kang File Added: volume_unmute_after_changing_channel.diff
2021-06-10 22:31 (SW) Jacky Chiang Assigned To (SW) Jacky Chiang => (SW) Jason Ling
2021-06-10 22:31 (SW) Jacky Chiang Note Added: 0007434
2021-06-11 09:02 (SW) Jason Ling Assigned To (SW) Jason Ling => (ALTech) Wooshin Kang
2021-06-11 09:02 (SW) Jason Ling Status assigned => resolved
2021-06-11 09:02 (SW) Jason Ling Resolution open => fixed
2021-06-11 09:02 (SW) Jason Ling Description Updated
2021-06-11 09:02 (SW) Jason Ling Note Added: 0007437
2021-06-16 08:48 (ALTech) Wooshin Kang File Added: 0001-ammend-of-BTVSBOX-501-Fix-unmute-issue-795027efe1dea.patch
2021-06-16 08:48 (ALTech) Wooshin Kang Note Added: 0007473
2021-06-16 08:49 (ALTech) Wooshin Kang Status resolved => feedback
2021-06-16 08:49 (ALTech) Wooshin Kang Resolution fixed => reopened
2021-06-16 08:49 (ALTech) Wooshin Kang Assigned To (ALTech) Wooshin Kang => (SW) Jason Ling
2021-06-16 11:01 (SW) Jason Ling Assigned To (SW) Jason Ling => (SW) Brent Choi
2021-06-16 11:01 (SW) Jason Ling Status feedback => resolved
2021-06-16 11:01 (SW) Jason Ling Resolution reopened => fixed
2021-06-16 11:01 (SW) Jason Ling Note Added: 0007474
2021-06-16 14:08 (SW) Brent Choi Assigned To (SW) Brent Choi => (ALTech) Wooshin Kang
2021-06-16 15:49 (ALTech) Wooshin Kang Note Added: 0007476
2021-08-18 15:32 (ALTech) Wooshin Kang Status resolved => closed
2021-08-18 15:32 (ALTech) Wooshin Kang Note Added: 0007907